Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get builds to run on all supported R versions #499

Merged
merged 14 commits into from
May 11, 2024
Merged

Conversation

IndrajeetPatil
Copy link
Member

@IndrajeetPatil IndrajeetPatil commented May 10, 2024

Testing workflows

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.55%. Comparing base (f044e18) to head (3275b6b).
Report is 4 commits behind head on main.

❗ Current head 3275b6b differs from pull request most recent head 45bd0da. Consider uploading reports for the commit 45bd0da to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   90.73%   90.55%   -0.19%     
==========================================
  Files          75       75              
  Lines        5809     5855      +46     
==========================================
+ Hits         5271     5302      +31     
- Misses        538      553      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil
Copy link
Member Author

This Matrix update is the bane of my existence.

@IndrajeetPatil IndrajeetPatil merged commit d74a225 into main May 11, 2024
25 of 27 checks passed
@IndrajeetPatil IndrajeetPatil deleted the expt-matrix-issues branch May 11, 2024 15:26
@IndrajeetPatil
Copy link
Member Author

giphy

@IndrajeetPatil IndrajeetPatil changed the title Update DESCRIPTION Get builds to run on all supported R versions May 11, 2024
@etiennebacher
Copy link
Member

Thanks a lot Indra!

@IndrajeetPatil
Copy link
Member Author

de rien!

But I am not sure if it still works. I had to make a lot of changes again to make sure things also work for performance, and not just datawizard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants